-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Code coverage task for coveralls #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we cared enough to go back to 2 spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I noticed that too, will fix before I check in if this system works. Either Sublime or VSCode must've auto-reformatted me.
|
Apparently the build must also take < 10min which code coverage does not so Travis is failing due to that |
|
Changes Unknown when pulling 2fc35a2 on codeCoverage into * on master*. |
|
Changes Unknown when pulling 3eb0ad9 on codeCoverage into * on master*. |
|
Changes Unknown when pulling e7df4ff on codeCoverage into * on master*. |
|
@danquirk what is the status of this PR? |
|
Was playing with it recently and got pulled off to other work. Unfortunately the nature of the task is such that I can't really do much testing locally. I'll just close it for now though. |
Testing code coverage task with Travis
Edit: not ready for checkin, but needed to submit a PR for testing purposes