Fix #8415: consider accessors when searching for contextually typed properties #8456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n searching for symbols
Contributor
Contributor
Author
src/compiler/utilities.ts
Outdated
| export function isLiteralComputedPropertyDeclarationName(node: Node) { | ||
| return (node.kind === SyntaxKind.StringLiteral || node.kind === SyntaxKind.NumericLiteral) && | ||
| node.parent.kind === SyntaxKind.ComputedPropertyName && | ||
| (<ComputedPropertyName>node.parent).expression === node && |
Contributor
Author
There was a problem hiding this comment.
you are right. removed.
Contributor
Author
|
@yuit any more comments? |
Contributor
|
lgtm 🍰 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8415
This also adds support for find all refs and rename for computed property names with literal expressions. in the past we just ignored computed properties all together, but we then excluded the numeric and string literal ones, but never added the LS support for them.