Always set _detailsPresenter.Content even if SelectedItem is null #1199
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
This would mean that people using MapDetails would need to check for null now when previously they did not. |
| _detailsPresenter.Content = MapDetails == null | ||
| ? SelectedItem | ||
| : MapDetails(SelectedItem); | ||
| _detailsPresenter.Content = MapDetails == null ? SelectedItem : SelectedItem != null ? MapDetails(SelectedItem) : null; |
There was a problem hiding this comment.
This is a lot happening on one line. Could you please change to:
_detailsPresenter.Content = MapDetails == null
? SelectedItem
: SelectedItem != null ? MapDetails(SelectedItem) : null;
| _detailsPresenter.Content = MapDetails == null | ||
| ? SelectedItem | ||
| : MapDetails(SelectedItem); | ||
| _detailsPresenter.Content = MapDetails == null |
There was a problem hiding this comment.
Sorry to seem like a jerk, but please make sure the file is formatted properly. These new changes have only three spaces for a tab rather than four.
There was a problem hiding this comment.
No worries, I have different standards installed on this machine - Making sure spacing is consistent IS a battle worth fighting.
| : SelectedItem != null ? MapDetails(SelectedItem) : null; | ||
| } | ||
| } | ||
| } |
5 participants
Fixes #1197
(and likely #745 as well)