Hamburger menu item style #1239
Conversation
| /// Identifies the <see cref="OpenPaneLength"/> dependency property. | ||
| /// </summary> | ||
| public static readonly DependencyProperty OpenPaneLengthProperty = DependencyProperty.Register(nameof(OpenPaneLength), typeof(double), typeof(HamburgerMenu), new PropertyMetadata(240.0)); | ||
| public static readonly DependencyProperty OpenPaneLengthProperty = DependencyProperty.Register(nameof(OpenPaneLength), typeof(double), typeof(HamburgerMenu), new PropertyMetadata(320)); |
There was a problem hiding this comment.
This feels like a breaking change, I'll note it in the release notes
There was a problem hiding this comment.
Not a breaking change. Just a change in the default style
There was a problem hiding this comment.
You are correct. I will still note it as a change in the release notes for those using the default style
There was a problem hiding this comment.
Isn't that the point of changing the styles. So those that use the default style now look like the nav view?
There was a problem hiding this comment.
Agreed. Release notes should still have the changes, as always :)
There was a problem hiding this comment.
Not saying not to 😁
|
|
||
| /// <summary> | ||
| /// Identifies the <see cref="Tag"/> dependency property. | ||
| /// </summary> |
There was a problem hiding this comment.
This seems like a big breaking change? Any way we can deprecate it first?
There was a problem hiding this comment.
Not a breaking change. Class now inherits from Control which already has a Tag property
4 participants
Update the style of the HambugerMenu items to match the new style of the NavigationView
Relates to #1185