Remove unneeded allocations in ItemSpec.MatchesItem #2330
Merged
rainersigwald merged 2 commits intodotnet:masterfrom Jul 20, 2017
davkean:MatchesItem
Merged
Remove unneeded allocations in ItemSpec.MatchesItem #2330rainersigwald merged 2 commits intodotnet:masterfrom davkean:MatchesItem
rainersigwald merged 2 commits intodotnet:masterfrom
davkean:MatchesItem
Conversation
This is in preparation to avoid boxing the enumerator.
This was allocating a capture class, Func and boxing the enumerator of Fragments.
Member
Author
|
Most of the allocations in this method is coming from ComparePathsNoThrow (200 MB) - are we fixing that? @dsplaisted @cdmihai |
AndyGerlicher
approved these changes
Jul 20, 2017
rainersigwald
approved these changes
Jul 20, 2017
Member
Author
|
@AndyGerlicher @rainersigwald Can we merge this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was allocating a capture class, Func and boxing the enumerator of Fragments: