[CodePush] The file “unzipped” couldn’t be opened - unzippedFolderPath appears as a file instead of a folder

[andrewrt]

Steps to Reproduce

1. Install CodePush via manual method to xcode project
2. Ensure that CodePush is using its own SSZipArchive library
3. In react native - app.js:

import codePush from 'react-native-code-push';
class App extends React.Component {

  codePushDownloadDidProgress = (progress) => {
    console.log(`${progress.receivedBytes} of  ${progress.totalBytes}  received.`);
  }

  componentDidMount() {
    codePush.sync(
      {
        updateDialog: true,
        installMode: codePush.InstallMode.IMMEDIATE,
      },
      (syncStatus) => {/*log status*/},
      (progress) => { this.codePushDownloadDidProgress(progress); }
    );
  }
 }

const codePushOptions = { checkFrequency: codePush.CheckFrequency.MANUAL };
// const codePushOptions = { checkFrequency: codePush.CheckFrequency.ON_APP_RESUME };
const MyApp = codePush(codePushOptions)(App);
export default MyApp;

Expected Behavior

Bundle downloads and installs

Actual Behavior

Console outputs:

2018-11-20 14:47:59.576 [info][tid:com.facebook.react.JavaScript] 'CodePush syncStatus: ', 7
2018-11-20 14:48:00.031 [info][tid:com.facebook.react.JavaScript] 17996 of  1247495  received.
2018-11-20 14:48:00.063 [info][tid:com.facebook.react.JavaScript] 50764 of  1247495  received.
2018-11-20 14:48:00.097 [info][tid:com.facebook.react.JavaScript] 99916 of  1247495  received.
2018-11-20 14:48:00.403 [info][tid:com.facebook.react.JavaScript] 1247495 of  1247495  received.
2018-11-20 14:48:00.499 [info][tid:com.facebook.react.JavaScript] 'CodePush syncStatus: ', 3
2018-11-20 14:48:00.500 [info][tid:com.facebook.react.JavaScript] [CodePush] The file “unzipped” couldn’t be opened.

Bundle downloads successfully, but then the unzip inside of CodePush appears to unzip the package as a file instead of a folder, so in CodePushPackage.m

 [SSZipArchive2 unzipFileAtPath:downloadFilePath  toDestination:unzippedFolderPath];

the phone's folder structure looks like:
/Library/Application Support/CodePush:

• download.zip (correct 1.2MB zip with my package, assets, etc etc)
• unzipped (a 3.6MB file without type)

Environment

• react-native-code-push version: "react-native-code-push": "^5.4.2",
• react-native version: "react-native": "0.56.x",
• iOS version: iOS 12.0.1
• Does this reproduce on a debug build or release build? Happens on both release and debug
• Does this reproduce on a simulator, or only on a physical device? Physical device & simulator

[andrewrt]

(I've renamed SSZipArchive to SSZipArchive2 in order to avoid naming collision as I saw that CodePush appears to be rolling your own version of SSZipArchive - and I wanted to be sure to run CodePush as you had intended).

In the end - this made no difference tho

[yuri-kulikov]

Hi @andrewrt,
Thanks for reporting!

I've tested it and in my case it works as it should (unzipped is a folder):

I've also renamed SSZipArchive to SSZipArchive2 for clarity.
It would be very helpful if you could provide us with a simple reproducible demo because I cannot reproduce the issue.

[andrewrt]

Thanks for the quick response @yuri-kulikov !
And thanks for running a test. About the above test - this is with CodePush manually installed instead of cocoapods?

As I have RN and a # of other libs directly linked (not with cocoapods), it's not all too easy for me to use the cocoapods method of linking for CodePush due it requiring RN to be linked from cocoapods as well (causing naming collisions / etc).

I'll try re-installing codepush with the current code base, and also making a fresh project to see what I can get

[yuri-kulikov]

@andrewrt, I don't use cocoapods in this project either.

I'm using very simple project:

• react-native init ...
• yarn add react-native-code-push
• react-native link react-native-code-push

[andrewrt]

@yuri-kulikov -
It appears that react-native link react-native-code-push will search for CocoaPods and if it finds something - it tries to link CodePush via cocoapods instead of using the non-cocoapods method...

Do you know what specifically the react-native-code-push link script is looking for?

(I have cocoapods for some external stuff - but don't want to use it for this as per the above)

[andrewrt]

Looks like it was looking for the PodFile... and maybe a few other things.
Removing the podfile, pods, etc temporarily and then running link appears to be working.
Additionally - your tests as well were working.

I must have missed something in the manual setup based on ^^^

Thanks again!

[yuri-kulikov]

That's great!
Thanks for using CodePush!