[Android] restartApp() throwing exception w/ release build

[lgn-lvx3]

I was able to reproduce this issue with the CodePushDemoApp below. Running a codePush.restartApp() without any pending updates or anything is throwing a fatal exception, android only. In my app (not demo one provided) I implemented the background ReactInstance implementation stuff and it still is throwing the same exception.

Reproduction

Added a button that calls CodePush.restartApp()
Here is the stack trace:
05-19 07:53:12.988 5735 5735 E AndroidRuntime: com.facebook.jni.CppException: facebook::react::Recoverable: Could not open fileassets://index.android.bundle: No such file or directory
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.cxxbridge.CatalystInstanceImpl.jniLoadScriptFromFile(Native Method)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.cxxbridge.CatalystInstanceImpl.loadScriptFromFile(CatalystInstanceImpl.java:208)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.cxxbridge.JSBundleLoader$2.loadScript(JSBundleLoader.java:53)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.cxxbridge.CatalystInstanceImpl.runJSBundle(CatalystInstanceImpl.java:221)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:935)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.ReactInstanceManager.access$600(ReactInstanceManager.java:104)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.ReactInstanceManager$ReactContextInitAsyncTask.doInBackground(ReactInstanceManager.java:218)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at com.facebook.react.ReactInstanceManager$ReactContextInitAsyncTask.doInBackground(ReactInstanceManager.java:197)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at android.os.AsyncTask$2.call(AsyncTask.java:295)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:237)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
05-19 07:53:12.988 5735 5735 E AndroidRuntime: at java.lang.Thread.run(Thread.java:818)

Additional Information

• react-native-code-push version: ^2.0.2-beta
• react-native version: 0.43.3
• iOS/Android/Windows version: API 23
• Does this reproduce on a debug build or release build? Only in release
• Does this reproduce on a simulator, or only on a physical device? Simulator

(The more info the faster we will be able to address it!)

[EwyynTomato]

I believe this this caused by the following lines in CodePushNativeModule.java:

            Method[] methods = jsBundleLoaderClass.getDeclaredMethods();
            for (Method method : methods) {
                if (method.getName().equals("createFileLoader")) {
                    createFileLoaderMethod = method;
                    break;
                }
            }

calling the method createFileLoader in com.facebook.react.cxxbridge > JSBundleLoader.java, but the method that should be called was createAssetLoader instead.

[max-mironov]

@EwyynTomato - thank you so much for pointing at this, I've created PR that should fix the issue - #861.
@hzyio, @EwyynTomato - could you please check to see if this soultion works for you? (from my side I've also tested it with emulator/real device on signed/unsigned apk with fresh install and codepush updates applied).

If you guys have any reason if it can be implemented other ways - please voice your concerns.

[max-mironov]

@hzyio, @EwyynTomato - guys, just a friendly ping, do you have a chance to look at this?

[lgn-lvx3]

No I haven’t yet, will try to get to it today.

…

On May 31, 2017, at 1:34 AM, Max ***@***.***> wrote: @hzyio <https://github.com/hzyio>, @EwyynTomato <https://github.com/ewyyntomato> - guys, just a friendly ping, do you have a chance to look at this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#847 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALva8BvFKAHtFxZANgOIndeCumpzBqDks5r_SYjgaJpZM4Ngo6C>.

[max-mironov]

@hzyio I'm going to close the issue as I believe the fix is merged in Master, please test it when you have time and provide us with your feedback. For sure reopen the issue if you see any problems with this.

[lgn-lvx3]

@max-mironov Sounds good. I do plan on testing this, will comment again if I have an issue.