Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Added compatibility with latest RN version(0.56) #1342

Merged
alexandergoncharov-zz merged 2 commits intomasterfrom
Goncharov/Upgrade_compileSdkVersion
Jul 10, 2018
Merged

Added compatibility with latest RN version(0.56) #1342
alexandergoncharov-zz merged 2 commits intomasterfrom
Goncharov/Upgrade_compileSdkVersion

Conversation

@alexandergoncharov-zz
Copy link
Copy Markdown
Contributor

@alexandergoncharov-zz alexandergoncharov-zz commented Jul 9, 2018

  • Added using project-wide properties.
  • Upgrade default compileSdkVersion to 26 version
  • Upgrade default buildToolsVersion to 26.0.3 version
  • Upgrade default targedSdkVersion to 26 version

Versions in React-native: https://github.com/facebook/react-native/blob/master/ReactAndroid/build.gradle#L247-L253

* Upgrade buildToolsVersion to 26.0.3 version
* Upgrade targedSdkVersion to 26 version
@alexandergoncharov-zz alexandergoncharov-zz changed the title Sync compileSdkVersion, buildToolsVersion, targedSdkVersion with RN@0.56 version Added compatibility with latest RN version(0.56) Jul 9, 2018
Copy link
Copy Markdown
Contributor

@max-mironov max-mironov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krystofbe
Copy link
Copy Markdown

@alexandergoncharov Thanks! I've tested your changes and it works now!

@alexandergoncharov-zz
Copy link
Copy Markdown
Contributor Author

Hi @krystofbe
Thanks for testing!

@alexandergoncharov-zz alexandergoncharov-zz merged commit c876971 into master Jul 10, 2018
@alexandergoncharov-zz alexandergoncharov-zz deleted the Goncharov/Upgrade_compileSdkVersion branch September 14, 2018 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants