Skip to content
This repository was archived by the owner on Feb 28, 2026. It is now read-only.

Set tab color default off and add config for fill/border#452

Merged
MattIrv merged 1 commit intomasterfrom
mairvine/tabColorFinish
Jan 9, 2018
Merged

Set tab color default off and add config for fill/border#452
MattIrv merged 1 commit intomasterfrom
mairvine/tabColorFinish

Conversation

@MattIrv
Copy link
Copy Markdown
Contributor

@MattIrv MattIrv commented Jan 8, 2018

This PR makes a few minor changes to tab coloring, per our design discussion earlier:

  • Disables it by default
  • Allows it to be toggled between off/border/fill to let users configure whether to fill the tab or just set the border color
  • Makes the colored border 1px thicker so that it is more visible
  • Makes the colored background less transparent when the tab is active to make it more visible

Border:
screen shot 2018-01-08 at 2 10 49 pm
screen shot 2018-01-08 at 2 11 35 pm

Fill:
screen shot 2018-01-08 at 2 11 07 pm
screen shot 2018-01-08 at 2 11 19 pm

@MattIrv MattIrv force-pushed the mairvine/tabColorFinish branch from 7342824 to 002e0e7 Compare January 8, 2018 22:22
@MattIrv MattIrv requested a review from kburtram January 8, 2018 23:52
@MattIrv MattIrv merged commit 5e4b892 into master Jan 9, 2018
@MattIrv MattIrv deleted the mairvine/tabColorFinish branch January 9, 2018 01:05
@martincroft
Copy link
Copy Markdown

The tab color (colour) doesn't show very well in some of the color themes i.e the high-contrast one, would the ability to change the colour of the database icon be an option?
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants