Convert to Python3. Use PEP8 naming conventions and formatting.#2
Closed
ntoll wants to merge 1 commit into
Closed
Conversation
khawley
reviewed
May 14, 2018
|
|
||
| def boardID(path): | ||
|
|
||
| def board_id(path): |
There was a problem hiding this comment.
Looks like the calls to the function didn't get renamed. (line 120 & line 179)
Contributor
|
I think you might have patched an old version, without .hex file support. |
Contributor
|
python3 conversion was done later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been playing with CircuitPython and the Circuit Playground Express. Wanting to flash the device with a new build I ran across this script.
As a courtesy I've converted it from Python 2 (soon to be unsupported) to Python 3 (they tell me it's the future). I've also renamed a few things and changed formatting to conform roughly with the PEP8 Python style guide (https://www.python.org/dev/peps/pep-0008/).
There are no tests! However, I can only confirm the script converts a CircuitPython
.binfile to.uf2and that the device flashed with the resultingfirmware.uf2file works:I've made a cursory check with my eyeball Mk.1 but YMMV with the other functionality. Please check.
Thanks for the tool, the usefulness of uf2 and I hope this is helpful. :-)