Don't fail with "impossible" compile error - fixes #1143 #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
changed the title
src/fsharp/TastOps.fs
Outdated
Contributor
There was a problem hiding this comment.
I believe this should just be stripTyEqnsAndMeasureEqns here.
Contributor
Author
There was a problem hiding this comment.
Ok let me check if it fixes it
Contributor
Author
There was a problem hiding this comment.
yep that works. PR updated
Contributor
|
This looks good to me, the fix is very appropriate - we should always have been stripping units of measure here. I wonder if we can add a test. I know the original repro is complex though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dsyme for #1143 we run into a missing pattern match (see diff). I copied the match case from the outer pattern match and the compile error is gone. I'm not sure if this is the correct fix...
/cc @swlaschin
UPDATE: @dsyme suggested a better fix. PR updated