Fix #3737 - allow inheriting from FSharpFunc #4804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
This was referenced Apr 30, 2018
dsyme
added a commit
to fsharp/fsharp
that referenced
this pull request
Apr 30, 2018
Cheery pick dotnet/fsharp#4804
Contributor
Author
|
ok, this is ready |
Contributor
Author
|
I extended this with a fix for regression #4569 which had a similar cause |
Contributor
Author
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
KevinRansom
approved these changes
May 3, 2018
KevinRansom
pushed a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3737 - allow inheriting from FSharpFunc
A crucial piece of Xamarin tooling (the CIL interpreter in Xamarin LivePlayer) relies on being able to extend FSharpFunc. Without this, even basic uses of LivePlay can't work on F# code.
I've discussed this with @praeclarum and it's a reasonable usage scenario for creating inheritance-based implementations of
FSharpFuncin F# user code