New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nullable `targetTypes` property for advanced debugging. #727

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@stristr
Contributor

stristr commented Sep 10, 2018

Follow-up PR to vscode-chrome-debug-core #350, this PR uses the new API to expose targetTypes as a property controlling the available types of debug targets in vscode-chrome-debug. As before, ["page"] is the default. This property can be set to something like ["page", "webview", "service_worker"], or null to disable filtering by target type entirely.

Prior art: #713, #623.

Please note that the package.nls.*.json files need translation for the new property.

@roblourens roblourens added this to the September 2018 milestone Sep 10, 2018

@roblourens

Thanks for the PR!

@roblourens roblourens merged commit 5908efd into Microsoft:master Sep 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment