Skip to content

Update walkthrough#10707

Merged
Colengms merged 21 commits intomainfrom
update-walkthrough
Apr 8, 2023
Merged

Update walkthrough#10707
Colengms merged 21 commits intomainfrom
update-walkthrough

Conversation

@bobbrow
Copy link
Copy Markdown
Member

@bobbrow bobbrow commented Mar 20, 2023

Let's use this PR to mark what still needs to happen in this branch to complete the walkthrough.

@sean-mcmanus
Copy link
Copy Markdown
Contributor

sean-mcmanus commented Mar 27, 2023

Is this ready for review or who is working on this?

@AlexandraKemperMS
Copy link
Copy Markdown

AlexandraKemperMS commented Mar 27, 2023

Is this ready for review or who is working on this?

Not yet - we still need to add the functionality listed in this work item: #8304 (comment)
I started updating the code to reference the quickpick and added a ToDo where that needs to be finished. Also, the svgs are not ready.

@bobbrow bobbrow linked an issue Mar 27, 2023 that may be closed by this pull request
C++ Walkthrough improvements #8304
Closed
bobbrow
bobbrow commented Mar 27, 2023
View reviewed changes
Comment thread Extension/package.json Outdated
bobbrow
bobbrow commented Mar 27, 2023
View reviewed changes
Comment thread Extension/src/LanguageServer/ui_new.ts
@bobbrow bobbrow added this to the 1.15 milestone Mar 29, 2023
sean-mcmanus
sean-mcmanus reviewed Apr 7, 2023
View reviewed changes
Comment thread Extension/package.nls.json Outdated
bobbrow
bobbrow commented Apr 7, 2023
View reviewed changes
Comment thread Extension/walkthrough/installcompiler/install-gcc-linux-short.md
michelleangela
michelleangela previously approved these changes Apr 7, 2023
View reviewed changes
sean-mcmanus
sean-mcmanus requested changes Apr 7, 2023
View reviewed changes
Comment thread Extension/package.nls.json Outdated
sean-mcmanus
sean-mcmanus reviewed Apr 7, 2023
View reviewed changes
Comment thread Extension/package.nls.json Outdated
sean-mcmanus
sean-mcmanus reviewed Apr 7, 2023
View reviewed changes
Comment thread Extension/package.nls.json Outdated
sean-mcmanus
sean-mcmanus reviewed Apr 7, 2023
View reviewed changes
Comment thread Extension/package.nls.json Outdated
sean-mcmanus
sean-mcmanus reviewed Apr 7, 2023
View reviewed changes
Comment thread Extension/walkthrough/devcommandprompt/open-developer-command-prompt.md Outdated
sean-mcmanus
sean-mcmanus reviewed Apr 7, 2023
View reviewed changes
Comment thread Extension/package.nls.json Outdated
sean-mcmanus
sean-mcmanus previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sean-mcmanus sean-mcmanus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A made a bunch of capitalization inconsistency comments.

@Colengms Colengms dismissed stale reviews from sean-mcmanus and michelleangela via 82864e2 April 7, 2023 23:30
@Colengms Colengms merged commit 0ec40d9 into main Apr 8, 2023
@Colengms Colengms deleted the update-walkthrough branch April 8, 2023 00:35
@github-actions github-actions Bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Colengms Colengms Colengms left review comments

@AlexandraKemperMS AlexandraKemperMS AlexandraKemperMS left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

+1 more reviewer

@michelleangela michelleangela michelleangela left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

C++ Walkthrough improvements

6 participants

@bobbrow @sean-mcmanus @AlexandraKemperMS @michelleangela @Colengms @jureid