Merged
Conversation
…nto coleng/fix_stuck_provider_id
sean-mcmanus
requested changes
Apr 5, 2023
Contributor
sean-mcmanus
left a comment
There was a problem hiding this comment.
This breaks the 1 provider auto-select scenario (the 2 provider scenario is fixed). I see this.configuration.CurrentConfigurationProvider return '' instead of the 1 provider.
…o c_cpp_properties.json exists
…correctly prior to configuration modifications
sean-mcmanus
approved these changes
Apr 5, 2023
michelleangela
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing a scenario in which one provider will register, get automatically selected because it's the only one (and then provide a browse configuration), but not get properly un-selected when a subsequent provider registers.
Removed a check that was opportunistically using a configuration provider if registered and if we received a browse configuration for it, as this scenario would lead to the 'too early' automatically selected config provider being kept.
We have a pattern in place to clear out any modifications we had made to the configuration (by calling
parsePropertiesFileagain) when we need to reprocess it. But, that was a NO-OP if there was noc_cpp_properties.jsonfile, so our modifications would not get removed in that scenario (making the prior registered configuration provider look like the user had explicitly specified it). I updated that to instead use the default configuration, and I needed to fix one place where we didn't do that reset if the contents were empty.