Address some issues where spread operator was used but deep copy needed#10803
Merged
sean-mcmanus merged 4 commits intomainfrom Apr 11, 2023
Merged
Address some issues where spread operator was used but deep copy needed#10803sean-mcmanus merged 4 commits intomainfrom
sean-mcmanus merged 4 commits intomainfrom
Conversation
sean-mcmanus
approved these changes
Apr 11, 2023
browntarik
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spread operator only copies 1 level deep. Any objects or arrays the source object will be 'referenced' by the new object, not copied.
Updated existing uses of the spread operator where it looks like a deep copy was intended.
Uses the module
lodashfor itscloneDeepfunction. But we could roll our own instead, if that would be preferable.