Skip to content

Add new "console" launch config for cppvsdbg#6794

Merged
WardenGnaw merged 6 commits intomainfrom
dev/waan/vsdbgConsole
Jan 16, 2021
Merged

Add new "console" launch config for cppvsdbg#6794
WardenGnaw merged 6 commits intomainfrom
dev/waan/vsdbgConsole

Conversation

@WardenGnaw
Copy link
Copy Markdown
Member

This PR adds new console support for the cppvsdbg debug type.

This removes the legacy 'externalConsole' flag with 'console'.
Console has four enums:

  • internalConsole: Output to the VS Code Debug Console. This doesn't
    support reading console input (ex:Console.ReadLine)
  • integratedTerminal: VS Code's integrated terminal
  • externalTerminal: External terminal that can be configured via user
    settings
  • newExternalWindow: Console applications will be launched in their own
    external console window which will end when the application stops.
    Non-console applications will run without a terminal, and
    stdout/stderr will be ignored

@gregg-miskelly

@WardenGnaw WardenGnaw self-assigned this Jan 15, 2021
This PR adds new console support for the cppvsdbg debug type.

This removes the legacy 'externalConsole' flag with 'console'.
Console has four enums:
- internalConsole: Output to the VS Code Debug Console. This doesn't
  support reading console input (ex:Console.ReadLine)
- integratedTerminal: VS Code's integrated terminal
- externalTerminal: External terminal that can be configured via user
  settings
- newExternalWindow: Console applications will be launched in their own
  external console window which will end when the application stops.
  Non-console applications will run without a terminal, and
  stdout/stderr will be ignored.
@WardenGnaw WardenGnaw force-pushed the dev/waan/vsdbgConsole branch from 969bde8 to aad7725 Compare January 15, 2021 21:46
Comment thread Extension/package.json
Copy link
Copy Markdown
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@sean-mcmanus sean-mcmanus requested a review from a team January 15, 2021 23:25
Comment thread Extension/package.json Outdated
Comment thread Extension/package.nls.json Outdated
Comment thread Extension/package.nls.json Outdated
@corneliusroemer
Copy link
Copy Markdown

corneliusroemer commented May 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants