Fix bug: !err && stats && stats.isFile will always return true. Fix typos#8897
Fix bug: !err && stats && stats.isFile will always return true. Fix typos#8897bobbrow merged 3 commits intomicrosoft:mainfrom
Conversation
|
Hello: Do I need to review it myself or wait for someone? |
|
We will review and commit it. Monday was a holiday for MSFT so no one had a chance to look yet. |
|
Thanks 😄 BTW: I cloned the source code of cpptools and debugged it in VSCode via F5. But I got the binary missing error:
I checked the cpptools vsix package downloaded from ms market and there are two executable files |
See https://github.com/microsoft/vscode-cpptools/blob/main/Documentation/Building%20the%20Extension.md |
Thank you for your response! The document says I need to download the cpptools extension from the Visual Studio Marketplace and copy its binaries |
|
@inlann Yes, you can't generate the cpptools and cpptools-srv binaries -- changing the TypeScript doesn't affect the binaries. |
|
@sean-mcmanus Thanks so much 😄 That's really helpful |

Hello:
I found the
if(!err && stats && stats.isFile)in thesrc/Debugger/configurationProviderwill always return true. It should beif(!err && stats && stats.isFile()).Also found some typos and fixed them 😄