Merged
Conversation
Member
|
Why would we be blocked on cpptools-srv updating? We should terminate all of those processes immediately since they don't save any state that we care about (I thought we did this already). There is no need to wait for them to finish. |
Contributor
Author
That's what the existing code does. I'm guessing it could lead to a corrupt ipch file, right? |
Colengms
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required in order for cpptools to be guaranteed to shutdown cleanly (all destructors run and threads exited), because it may be blocked on cpptools-srv updating. In particular, temp files might not be properly deleted.
This change requires cpptools-side changes as well.