Contribute breakpoints for the "rust" language

[chuckries]

Since rust code can be debugged with this extension, contribute breakpoints for the "rust" language such that the workaround of "allow breakpoints in all files" is no longer required.

[chuckries]

fixes #75 for rust only

[WardenGnaw]

@gregg-miskelly

Do we want to set contributes.debugger.languages: [ ..., "rust"] to both debuggers?

[chuckries]

I wasn't sure about "languages" as we don't offer any language features for rust? just bp support.

I tried disabling the rust-analyzer extension and turned off "bps can be set in any file" and was still able to set bps in .rs files.

[WardenGnaw]

languages those languages for which the debug extension could be considered the "default debugger"

The languages contribute seems to be specific to debugging which we are allowing.

https://code.visualstudio.com/api/references/contribution-points#contributes.debuggers

[chuckries]

@WardenGnaw updated to contribute languages for rust

[WardenGnaw]

Just adding here as a note to update the docs:
https://code.visualstudio.com/docs/languages/rust#_using-rust-analyzer-debug

Edit: Link to doc's md. https://github.com/microsoft/vscode-docs/blob/40f4f497a5954bb5b61c9412d36f381a605336e4/docs/languages/rust.md?plain=1#L247-L249

[gregg-miskelly]

Do we want to set contributes.debugger.languages: [ ..., "rust"] to both debuggers?

I think so.

[WardenGnaw]

Also add "onLanguage:rust", so the extension activates when selecting a rust file.

vscode-cpptools/Extension/package.json

Line 50 in 4a85594

"onLanguage:cuda-cpp",

[gregg-miskelly]

Also add "onLanguage:rust", so the extension activates when selecting a rust file.

vscode-cpptools/Extension/package.json

Line 50 in 4a85594

"onLanguage:cuda-cpp",

Is there a reason we need to? I didn't see any issues without this.

[chuckries]

@gregg-miskelly at least from my experience, the debugger wouldn't activate if only viewing rust files, which prevented C++ from showing up as a launch.json template source. I'd need to test again to confirm.

[chuckries]

@gregg-miskelly selecting Run and Debug with a .rs file active:

selecting it with a .cpp file active:

I'm not actually sure what the correct fix is here. I thought it was an issue of extension activation but it appears based on the active editor. C++ doesn't show up for the .rs file even after opening a .cpp file.

[chuckries]

@gregg-miskelly @WardenGnaw even if I can get the C++ options to pop up from Run and Debug and I select C++ (Windows), then select Default Configuration, I get this:

I'm not sure how far we want to go at this point, given that a lot of this starts to get C++ specific. It'd be nice to get a default config working for Rust, but I feel like its probably non trivial to stand up and support?

[WardenGnaw]

I believe this is due to the changes of Run and Debug by @elahehrashedi .

A lot of the config generation is done by the C++ language service now.

[chuckries]

@gregg-miskelly I'm curious how you started debugging rust if at all? Did you manually create a launch.json? Were you just using the inline hints provided by rust-analyzer?

[gregg-miskelly]

@gregg-miskelly at least from my experience, the debugger wouldn't activate if only viewing rust files, which prevented C++ from showing up as a launch.json template source. I'd need to test again to confirm.

That is what I saw too. But I wasn't sure if we would want the C++ templates to show up or not. If we do want it, I wonder if a better option is to activate on onDebugInitialConfigurations, which is what the C# extension does (see here).

The reason we might NOT want the C++ templates to show up is that the rust-analyze extension does offer their own templates through the 'Rust Analyzer: Debug' command.

[gregg-miskelly]

@gregg-miskelly I'm curious how you started debugging rust if at all? Did you manually create a launch.json? Were you just using the inline hints provided by rust-analyzer?

I tried it three different ways --

1. I manually created a launch.json before I read the docs.
2. I used 'Rust Analyzer: Debug' to generate a launch.json for me. That was fine, except it didn't add "preLaunchTask": "rust: cargo build" like I wanted.
3. I used 'Rust Analyzer: Debug' to debug without a launch.json

[sean-mcmanus]

This change is available in 1.11.2 (pre-release): https://github.com/microsoft/vscode-cpptools/releases

[sean-mcmanus]

It's actually in 1.10.8 (release) too: https://github.com/microsoft/vscode-cpptools/releases/tag/v1.10.8