Got "Breakpoint set but not yet bound" on debug start

[ruslan-bikkinin]

Hi everyone.

We are maintainers of vscode-react-native extension and recently we've got the following issue: microsoft/vscode-react-native#625 (comment) - for some reason, debugging does not stop on breakpoints on the first start, but it actually works as expected when we are removing and adding breakpoints again.

As we know, previously the following hack has been implemented to avoid such kind of problem, but currently it does not work https://github.com/Microsoft/vscode-react-native/blob/e315e3db8545c6f69dd85e9bb0b17b239e52500b/src/debugger/nodeDebugWrapper.ts#L205.

This issue DOES NOT reproduce on previous versions of Vs code such as 1.19.3 or 0.18.1, but DOES reproduce on the latest one: 1.20.1.

@roblourens here: microsoft/vscode-chrome-debug-core#293 (comment) supposes that something changed in vscode-node-debug2 between those versions.

We have a lot of users affected by this issue so we are hoping that somebody from vscode-node-debug2 team could help us to understand what is the cause of problem. Any advices, clues will be much appreciated as well.

[roblourens]

In the other issue I asked for a log file, are you able to provide a log file? In node and chrome-debug this is enabled when "trace": true is set in the launch config, you can probably pass this in from your extension.

[ruslan-bikkinin]

Hi @roblourens and sorry for such delayed response. I tried to do what you suggested to me, but, unfortunately, I couldn't gather any logs for some reason. Actually, I used this trick to pass trace argument to debug adapter but with no success:

// We are extending ChromeDebugAdapter class to inject hack for "set breakpoint" issue.
// I am using it as well to force internal logging for debug adapter.
export function makeAdapter(debugAdapterClass: typeof ChromeDebugAdapter): typeof ChromeDebugAdapter {
    return class extends debugAdapterClass {
        protected doAttach(port: number, targetUrl?: string, address?: string, timeout?: number): Promise<void | DebugProtocol.Capabilities> {
            // This is the hack we used to fix "set breakpoint" issue 

            // We need to overwrite ChromeDebug's _attachMode to let Node2 adapter
            // to set up breakpoints on initial pause event
            (this as any)._attachMode = false;
            return super.doAttach(port, targetUrl, address, timeout);
        }

        // Override .attach() to pass trace and logFilePath arguments.
        attach(args: IAttachRequestArgs): Promise<DebugProtocol.Capabilities | void>{

            // I tried this...
            //args.trace = "verbose";
            //args.logFilePath = "/home/rbikkinin/nodedebug.log";
 
            // ...and this..
            args.trace = true;
            
            // ...with no success
            return super.attach(args);
        }
    };
}

I even debugged extension to make sure all additional args had been passed inside debug adapter, too. What am I doing wrong? Please let me know if you have any clues.

[roblourens]

It should write the log file path to the debug console. It's not doing that? attach should call commonArgs, which calls logger.setup.

[ruslan-bikkinin]

@roblourens No, that's the point.

attach should call commonArgs, which calls logger.setup.

Yes, I saw this when I was debugging the debugger of extension, but for some reason it didn't help.

[roblourens]

Can you step into setup to figure out what goes wrong after that?

[ruslan-bikkinin]

@roblourens I'll try.

[dakdog320]

I think I'm experiencing the same behavior.

Launch config

{
"type": "node",
"request": "launch",
"name": "Jest Debug",
"program": "${workspaceRoot}/node_modules/jest/bin/jest",
"args": ["--runInBand"],
"internalConsoleOptions": "neverOpen",
"console": "integratedTerminal",
"trace": true
}

I have attached 2 trace files.

• breakpoint-not-hit.txt: trace with breakpoint set before launching Jest Debug which never gets hit.

• breakpoint-hit-after-start-debug-and-resetting.txt: trace where I launch Jest Debug and then spam adding and removing the breakpoint in my test while jest is running. This breakpoint usually gets hit (seems like i have to add the breakpoint while the file being tested by jest is in context for it to get hit every time).

VSCode:

Version 1.21.1
Commit 79b44aa704ce542d8ca4a3cc44cfca566e7720f1
Date 2018-03-14T14:46:47.128Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Node v9.10.1

Let me know if this helps.

[roblourens]

That's not related to this issue. Please try in Insiders since I fixed a similar issue. Open a new issue if it happens in Insiders. https://code.visualstudio.com/insiders

[dakdog320]

Thanks for the response. Having the same issue with Insider. Will post issue there.

Version 1.22.0-insider
Commit 6c22e21cdcd6811770ddcc0d8ac3174aaad03678
Date 2018-03-30T05:16:39.261Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

[ruslan-bikkinin]

Hi @roblourens and sorry for long delay. As I understand, logger hasn't _currentLogger instance and that's why it isn't write logs to file (please take a look at screenshot below):

I tried to force logger to be initialized by calling init() method but that didn't help.

        import { logger } from "vscode-chrome-debug-core";
// ...
        attach(args: IAttachRequestArgs): Promise<DebugProtocol.Capabilities | void> {
            args.trace = "verbose";
            args.logFilePath = "/home/rbikkinin/node-debug/log.log";
            //force logger to initialize
            logger.init((event: LogOutputEvent) => {
                //just for testing
                console.log(event);
            }, "/home/rbikkinin/node-debug/log.log", true);
            return super.attach(args);
        }

[roblourens]

The problem is that you load the node debug extension, but then also have your own separate copy of vscode-chrome-debug-core. The logger instance is stored as static state within the module, so in this case you have two separate instances.

I think it will work if you import the logger from node2's copy of vscode-chrome-debug-core and use that one instead.

[ASP-2014]

using VSCode version 1.21.0. Breakpoints still not working. It's really frustrating that still this is not resolved.