VSCode 1.31 broke npm shortcuts

[avxkim]

Before 1.31 i could press ⌘+R, Shift+R to run NPM scripts defined in my package.json, but now it doesn't work, i have to call command palette ⌘+Shift+P, only then i can use shortcut ⌘+R, Shift+R

[egamma]

I cannot reproduce this. Can you check in the keybindings editor whether you have customized the keybindings for ⌘+R

[avxkim]

It's not a custom keybinding:

[egamma]

In the editor search wheter ⌘+R is no bound to another command.

[avxkim]

No, it's not, it worked today just before 1.31 update applied...
⌘K, ⌘S supposed to open settings, but it's not working either, only after i launch command palette with ⌘+Shift+P, then it works just once. Seems like 1.31's bug.

[egamma]

Can you attach what you get when you search for cmd+r in the keybindings editor

[avxkim]

[avxkim]

So, have you reproduced this bug?

[egamma]

Works for me (see the attached movie). Also searched in the vscode issues, but I could not find similar issues. Can you try to assign another chording keybinding and check whether the issues is cmd+R specific.

[avxkim]

Well, i've tried ⌘K, ⌘S, when i pressed ⌘K nothing happens, i don't see the text in the bottom bar "⌘K was pressed, waiting for second key of chord". I've tried to launch vscode with extensions disabled, but still ⌘K, ⌘S didn't work, omg. If i revert back to 1.29, then it works. Obviously 1.31 messed something up.

[egamma]

Do the ⌘K keybindings work for you? Do you have a special keyboard?

In general this cannot be an issue with this extension. This looks like a VS Code keyboard issue. Please consult this trouble shooting guide https://github.com/Microsoft/vscode/wiki/Keybinding-Issues

[avxkim]

Do the ⌘K keybindings work for you? Do you have a special keyboard?

Nope, i'm using built-in macbook pro 13"s keyboard.

[avxkim]

@egamma, try to open Terminal window and focus it, then use ⌘R, Shift+R or ⌘K, ⌘S

[egamma]

@heihachi88 thank you for providing the reproducable case.

This is issue microsoft/vscode#22211, which has been closed as designed.