Doesn't work properly with git-lfs enabled repositories

[ntwrkguru]

• VSCode Version: Code 1.11.2 (6eaebe3, 2017-04-13T07:56:42.517Z)
• OS Version: Darwin x64 16.5.0
• Extensions:

Extension	Author	Version
markdown-toc	AlanWalk	1.5.1
vscode-markdownlint	DavidAnson	0.7.1
format-php	Kasik96	1.1.2
vscode-docker	PeterJausovec	0.0.13
vscode-wakatime	WakaTime	1.1.3
vscode-instant-markdown	dbankier	1.1.0
vscode-yaml-validation	djabraham	0.0.1
python	donjayamanne	0.6.1
php-debug	felixfbecker	1.10.0
ansible	haaaad	0.2.5
phpcs	ikappas	0.7.0
MagicPython	magicstack	1.0.9
Theme-MarkdownKit	ms-vscode	0.1.4
python	tht13	0.2.3
ansible-autocomplete	timonwong	0.0.2
jinja	wholroyd	0.0.7

---

Steps to Reproduce:

1. Commit to a git-lfs enabled repository
2. Attempt to push

This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting .git/hooks/pre-push.

error: failed to push some refs to 'git@server:user/repo.git'

However, git-lfs is, in fact, installed and working fine from the CLI:

$ git push
Authorized uses only. All activity may be monitored and reported.Counting objects: 9, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (9/9), 1.01 KiB | 0 bytes/s, done.
Total 9 (delta 4), reused 0 (delta 0)
To server:user/repo.git
   0ba3fb8..3a055ec  master -> master

Note that this happens even when not pushing LFS objects.

[joaomoreno]

Where is Git LFS installed? If you open the Developer Tools in Code, what does process.env.PATH return? What command prompt shell do you use?

[ntwrkguru]

@joaomoreno Thanks for the feedback.

> process.env.PATH
< "/usr/bin:/bin:/usr/sbin:/sbin"

So, it seems that VSCode is not looking in /usr/local/bin (which is where git-lfs is installed for me). How can I add /usr/local/bin to VSCode's PATH?

[EDIT] Strangely enough, my git is also in /usr/local/bin (unless VSCode runs it's own git process?)

$ which git
/usr/local/bin/git

$ which git-lfs
/usr/local/bin/git-lfs

[joaomoreno]

What shell do you use? Bash, ZSH, Fish?

Did you install LFS using Homebrew?

[ntwrkguru]

Sorry, it's Bash and yes, git-lfs was installed via Homebrew.

[joaomoreno]

What does which code return?

[ntwrkguru]

Null

[joaomoreno]

In Code, if you open the developer tools (F1, Developer Tools) and execute the following snippet, what do you get back?

process.lazyEnv.then(console.log, console.error)

[ntwrkguru]

process.lazyEnv.then(console.log, console.error)

Object {__CF_USER_TEXT_ENCODING: "0x24BD:0x0:0x0", TMPDIR: "/var/folders/b8/_qcrvvx13sb30l6rr28qzdn000095x/T/", HOME: "/Users/ssteiner", SHELL: "/bin/tcsh", SSH_AUTH_SOCK: "/private/tmp/com.apple.launchd.t0pfcYyBbP/Listeners"…}
Apple_PubSub_Socket_Render: "/private/tmp/com.apple.launchd.Cex6PtLsXH/Render"
COMMAND_MODE: "unix2003"
GOOGLE_API_KEY: "AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q"
HOME: "/Users/ssteiner"LOGNAME: "ssteiner"
PATH: "/usr/bin:/bin:/usr/sbin:/sbin"
SHELL: "/bin/tcsh"
SSH_AUTH_SOCK: "/private/tmp/com.apple.launchd.t0pfcYyBbP/Listeners"
TMPDIR: "/var/folders/b8/_qcrvvx13sb30l6rr28qzdn000095x/T/"
USER: "ssteiner"
VSCODE_IPC_HOOK: "/Users/ssteiner/Library/Application Support/Code/1.11.2-main.sock"
VSCODE_NLS_CONFIG: "{"locale":"en-us","availableLanguages":{}}"
VSCODE_NODE_CACHED_DATA_DIR_40161: "/Users/ssteiner/Library/Application Support/Code/CachedData"
VSCODE_PID: "40161"
XPC_FLAGS: "0x0"
XPC_SERVICE_NAME: "0"
__CF_USER_TEXT_ENCODING: "0x24BD:0x0:0x0"
__proto__: Objectconstructor: ()arguments: nullcaller: nulllength: 0name: ""prototype: Object__proto__: ()<function scope>__proto__: Object
Promise {[[PromiseStatus]]: "resolved", [[PromiseValue]]: undefined}

[joaomoreno]

Interesting. What if you paste the following snippet?

(() => {
const electron = require('electron').remote.process.execPath;
const cp = require('child_process');
const mark = 'MARK123';
const env = Object.assign({}, process.env, {
    ELECTRON_RUN_AS_NODE: '1',
    ELECTRON_NO_ATTACH_CONSOLE: '1'
});
const command = `'${electron}' -p '"${mark}" + JSON.stringify(process.env) + "${mark}"'`;
const result = cp.spawnSync(process.env.SHELL, ['-ilc', command], {
    detached: true,
    stdio: ['ignore', 'pipe', process.stderr],
    env,
    encoding: 'utf8'
});
console.log(result.stdout);
})();

[ntwrkguru]

undefined

BTW, thanks for looking into this! It's much appreciated. I recently moved from Atom to VSCode and love it!

[joaomoreno]

Wait, you don't seem to be using Bash, but tcsh. Check the value of process.env.SHELL.

[ntwrkguru]

VSCode is using tcsh, but my terminal is using bash...Sorry, I must have misunderstand.

[joaomoreno]

That is interesting. How do you think Code got to use tcsh? In a Terminal what does echo $SHELL return?