New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-render hovers if nothing has changed; Add telemetry on hovers #29387

Merged
merged 4 commits into from Oct 24, 2017

Conversation

Projects
None yet
5 participants
@dadlerj
Contributor

dadlerj commented Jun 24, 2017

See #29388

To illustrate the difference, I added a console.log whenever the ModesContentHoverWidget._renderMessages method is called.
See a video of how it behaves currently: https://cl.ly/2X2k0O1Z370q
And a video of how it behaves with my PR: https://cl.ly/0I15253M142X

The first commit adds the check for equality
The second commit adds telemetry for every hover

I'd be happy to kill the 2nd if you prefer it

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 24, 2017

@dadlerj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

mention-bot commented Jun 24, 2017

@dadlerj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

@alexandrudima alexandrudima added this to the October 2017 milestone Oct 24, 2017

@alexandrudima alexandrudima merged commit 6a99187 into Microsoft:master Oct 24, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla All CLA requirements met.
Details
@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Oct 24, 2017

Member

Thank you @dadlerj ❤️. I have removed the telemetry part from the PR and kept only the rendering part. Sorry for taking so long to merge this in!

Member

alexandrudima commented Oct 24, 2017

Thank you @dadlerj ❤️. I have removed the telemetry part from the PR and kept only the rendering part. Sorry for taking so long to merge this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment