New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly get apt dirs in debian postinst #35535

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@julian-klode
Contributor

julian-klode commented Oct 3, 2017

This previously used some crazy hack to parse the output of
apt-config dump, instead of using apt-config shell like
you are supposed to do.

Correctly get apt dirs in debian postinst
This previously used some crazy hack to parse the output of
`apt-config dump`, instead of using `apt-config shell` like
you are supposed to do.
@julian-klode

This comment has been minimized.

Show comment
Hide comment
@julian-klode

julian-klode Oct 3, 2017

Contributor

foo/d and foo/f lookup file paths following the hierarchy. /d adds a trailing directory separator, /f does not. The old code was a crude hack that would fail as soon as any component was an absolute path.

Contributor

julian-klode commented Oct 3, 2017

foo/d and foo/f lookup file paths following the hierarchy. /d adds a trailing directory separator, /f does not. The old code was a crude hack that would fail as soon as any component was an absolute path.

@Tyriar Tyriar added this to the October 2017 milestone Oct 4, 2017

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Oct 4, 2017

Member

Thanks for this @julian-klode, seems to work great

Member

Tyriar commented Oct 4, 2017

Thanks for this @julian-klode, seems to work great

@Tyriar Tyriar merged commit 0c30958 into Microsoft:master Oct 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment