New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code.iss to associate `.bib` files #36509

Merged
merged 2 commits into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@anchepiece
Contributor

anchepiece commented Oct 18, 2017

Adding in the required registry entries to associate .bib LaTeX bibliography files in the Windows environment. #28959

Update code.iss to associate `.bib` files
Adding in the required registry entries to associate `.bib` LaTeX bibliography files in the Windows environment. #28959

@mjbvz mjbvz requested a review from joaomoreno Oct 19, 2017

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Oct 19, 2017

Member

You forgot to replace Bash RC with a good file type description for .bib files.

Member

joaomoreno commented Oct 19, 2017

You forgot to replace Bash RC with a good file type description for .bib files.

@joaomoreno joaomoreno added this to the Backlog milestone Oct 19, 2017

@anchepiece

This comment has been minimized.

Show comment
Hide comment
@anchepiece

anchepiece Oct 22, 2017

Contributor

Corrected it @joaomoreno thanks for pointing that out. I just left the description as BibTeX as that looks most appropriate.

Contributor

anchepiece commented Oct 22, 2017

Corrected it @joaomoreno thanks for pointing that out. I just left the description as BibTeX as that looks most appropriate.

@anchepiece

This comment has been minimized.

Show comment
Hide comment
@anchepiece

anchepiece Oct 24, 2017

Contributor

Sorry, @joaomoreno it looks like the CI check fell over, not sure how to re-run that job.

Contributor

anchepiece commented Oct 24, 2017

Sorry, @joaomoreno it looks like the CI check fell over, not sure how to re-run that job.

@joaomoreno joaomoreno modified the milestones: Backlog, October 2017 Oct 27, 2017

@joaomoreno joaomoreno merged commit 80ab68e into Microsoft:master Oct 27, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Oct 27, 2017

Member

Thanks! 🍻

Member

joaomoreno commented Oct 27, 2017

Thanks! 🍻

@anchepiece anchepiece deleted the anchepiece:patch-1 branch Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment