New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update keytar to 4.0.5 #36849

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@stevedesmond-ca
Contributor

stevedesmond-ca commented Oct 24, 2017

atom/node-keytar#80 makes cross-compilation for ARM possible, which was just tagged/released to npm in 4.0.5.

VSCode cross-compilation has been failing since keytar was introduced in 1.15.

@chrmarti chrmarti added this to the October 2017 milestone Oct 24, 2017

@chrmarti

This comment has been minimized.

Show comment
Hide comment
@chrmarti

chrmarti Oct 30, 2017

Contributor

Update to the shrinkwrap file is missing, I'll add that. Thanks!

Contributor

chrmarti commented Oct 30, 2017

Update to the shrinkwrap file is missing, I'll add that. Thanks!

@chrmarti chrmarti merged commit 38ba2f0 into Microsoft:master Oct 30, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment