New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Include GitErrorData in GitError.toString #36971

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@keegancsmith
Contributor

keegancsmith commented Oct 26, 2017

We are passing GitErrorData to JSON.stringify to include in the string
generated by GitError.toString. However, we set replacer to [] which
means JSON.stringify will always serialize to { }. After this change
GitError messages should be more understandable, and not just say Failed to execute git { }.

git: Include GitErrorData in GitError.toString
We are passing `GitErrorData` to `JSON.stringify` to include in the string
generated by `GitError.toString`. However, we set `replacer` to `[]`, which
means `JSON.stringify` will _always_ serialize to `{ }`. After this change
GitError messages should be more understandable, and not just say `Failed to
execute git`.

@joaomoreno joaomoreno merged commit 178d056 into Microsoft:master Oct 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Oct 27, 2017

Member

Great catch, thanks! 🍻

Member

joaomoreno commented Oct 27, 2017

Great catch, thanks! 🍻

@joaomoreno joaomoreno added this to the October 2017 milestone Oct 27, 2017

@joaomoreno joaomoreno added the git label Oct 27, 2017

@keegancsmith keegancsmith deleted the keegancsmith:git-error-to-string branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment