New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global is undefined while polyfilling the native promise #37017

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@wenshiqi0
Contributor

wenshiqi0 commented Oct 27, 2017

For some reason, I have to compile the monaco-editor by myself.
Recently I update the monaco and found that the editor crash while loading the monaco.
It seems that we need polyfill the promise after we set the global.

2017-10-27 11 45 47

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Oct 27, 2017

Member

Thanks

Member

jrieken commented Oct 27, 2017

Thanks

@jrieken jrieken merged commit 3520939 into Microsoft:master Oct 27, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

@jrieken jrieken added this to the October 2017 milestone Oct 27, 2017

@jrieken jrieken added the bug label Oct 27, 2017

@wenshiqi0 wenshiqi0 deleted the wenshiqi0:fix-monaco branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment