New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moveSelectionToPreviousFindMatch accidentally mapped to addSelectionToPreviousFindMatch #37088

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@peterwmwong
Contributor

peterwmwong commented Oct 28, 2017

Currently when moveSelectionToPreviousFindMatch executes, instead of moving the selection it actually adds to the selection. This clearly is typo that accidentally snuck in with #36682

public moveSelectionToPreviousFindMatch(findController: CommonFindController): void {
this._beginSessionIfNeeded(findController);
if (this._session) {
this._applySessionResult(this._session.addSelectionToPreviousFindMatch());

/cc @alexandrudima

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima
Member

alexandrudima commented Oct 30, 2017

@peterwmwong Thank you

@alexandrudima alexandrudima self-assigned this Oct 30, 2017

@alexandrudima alexandrudima added this to the October 2017 milestone Oct 30, 2017

@alexandrudima alexandrudima merged commit 51c889b into Microsoft:master Oct 30, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment