Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different border styles for HC (#45479) #46956

Merged
merged 1 commit into from Apr 4, 2018

Conversation

@svipas
Copy link
Contributor

commented Mar 29, 2018

Fixes #45479

  • Changed all these new border colors to have solid instead of dotted | dashed. Using dotted | dashed only if the theme is HC.
  • Changed diffEditor.insertedTextBorder and diffEditor.removedTextBorder to be solid instead of dashed. Using dashed only if the theme is HC.

/cc @alexandrudima

@svipas

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2018

Seems there is some telemetry error and tests are failing. And I believe this happened after this commit 21bfdd4.

@svipas

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2018

Seems test are again stable and successful, how to trigger them to build again for this PR?

@alexandrudima

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

👍 Nice! Thank you!

@alexandrudima alexandrudima added this to the April 2018 milestone Apr 4, 2018

@alexandrudima alexandrudima merged commit 44b3ee2 into microsoft:master Apr 4, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.