Skip to content

Different border styles for HC (#45479)#46956

Merged
alexdima merged 1 commit into
microsoft:masterfrom
svipas:border-styles
Apr 4, 2018
Merged

Different border styles for HC (#45479)#46956
alexdima merged 1 commit into
microsoft:masterfrom
svipas:border-styles

Conversation

@svipas

@svipas svipas commented Mar 29, 2018

Copy link
Copy Markdown
Contributor

Fixes #45479

  • Changed all these new border colors to have solid instead of dotted | dashed. Using dotted | dashed only if the theme is HC.
  • Changed diffEditor.insertedTextBorder and diffEditor.removedTextBorder to be solid instead of dashed. Using dashed only if the theme is HC.

/cc @alexandrudima

@svipas

svipas commented Mar 29, 2018

Copy link
Copy Markdown
Contributor Author

Seems there is some telemetry error and tests are failing. And I believe this happened after this commit 21bfdd4.

@svipas

svipas commented Mar 29, 2018

Copy link
Copy Markdown
Contributor Author

Seems test are again stable and successful, how to trigger them to build again for this PR?

@alexdima

alexdima commented Apr 4, 2018

Copy link
Copy Markdown
Member

👍 Nice! Thank you!

@alexdima alexdima added this to the April 2018 milestone Apr 4, 2018
@alexdima alexdima merged commit 44b3ee2 into microsoft:master Apr 4, 2018
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Borders styles for selection and word highlight

2 participants