New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scrollbar to be considered as a drop target for drag-and-drop #49747

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
2 participants
@manixate

manixate commented May 12, 2018

Fixes: #48929

The approach here is to prevent scrollbar to be not considered a drop target when searching on dragover or dragleave. This behaviour is similar to how MacOS handles drag and drop while hovering on the scrollbar in Finder.

Another approach is basically to add drop event listener on the domNode instead of wrapper which will allow the user to drop any item on the scrollbar but the file will be dropped on the top level of the folder structure instead of in the scrolled position.

Let me know if you want another approach instead of the one in this PR.

@joaomoreno joaomoreno added this to the Backlog milestone May 28, 2018

@joaomoreno joaomoreno added the tree label May 28, 2018

@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 11, 2018

@joaomoreno joaomoreno merged commit e9ed38c into Microsoft:master Sep 11, 2018

1 check passed

license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 11, 2018

Member

Thanks! 🍻

Member

joaomoreno commented Sep 11, 2018

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment