New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added background ANSI colour codes #49764

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@danielfrankcom
Contributor

danielfrankcom commented May 12, 2018

Discussed in #47457.

Due to the fact that the previous changes are not yet on master, I couldn't figure out a way to isolate the relevant changes in this pull request. Focus on the changes in commit a253dae, as the other commit is captured in pull request #49763.

@isidorn

This comment has been minimized.

Contributor

isidorn commented May 14, 2018

@danielfrankcom thanks a lot for this PR, let's first merge in the previous one and then we can add this one easily.

@isidorn

This comment has been minimized.

Contributor

isidorn commented May 28, 2018

@danielfrankcom since we have merged the other PR we could look into this one now.
Though I guess it needs to be updated to be on top of the latest changes we just merged in.
Pushing this to june since there is no rush for this

@isidorn isidorn modified the milestones: May 2018, June 2018 May 28, 2018

@danielfrankcom

This comment has been minimized.

Contributor

danielfrankcom commented May 28, 2018

Yeah I'll need to rebase it, but everything should still work. I'll add the background colour codes to the unit tests too, since it should be relatively easy.

@isidorn

This comment has been minimized.

Contributor

isidorn commented May 28, 2018

Sounds good, thanks a lot!

@isidorn

This comment has been minimized.

Contributor

isidorn commented Jun 4, 2018

This looks good, let's merge it in.
Thanks a lot!

@isidorn isidorn merged commit 8e95a31 into Microsoft:master Jun 4, 2018

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment