Skip to content

{ "editor.wrappingIndent": "deepIndent" } for 2 additional tabs on continuation lines#50542

Merged
alexdima merged 1 commit intomicrosoft:masterfrom
h-h-h-h:allow-deep-indent-as-line-wrapping-mode
May 28, 2018
Merged

{ "editor.wrappingIndent": "deepIndent" } for 2 additional tabs on continuation lines#50542
alexdima merged 1 commit intomicrosoft:masterfrom
h-h-h-h:allow-deep-indent-as-line-wrapping-mode

Conversation

@h-h-h-h
Copy link
Copy Markdown
Contributor

@h-h-h-h h-h-h-h commented May 28, 2018

This PR introduces the deepIndent preference value.

Here's an example from the VS Code codebase with an editor.wrappingIndent value of indent which, at first, confused me regarding the opening brace in ILineMapping {:

indent

Here's the same code with a preference value of deepIndent:

deepIndent

Here's some proof of manual indentation that other people also like this style:

The overwhelming advantage is in the context of block headers when lines follow that are indented deeper by one level. But even in the context of lines all on the same indentation level, it's totally okay in my opinion.

…pIndent".

The preference value "indent" adds 1 tab to the indentation of continuation lines, additionally to the indentation of the line of text in memory. "deepIndent" adds 2 tabs.
@msftclas
Copy link
Copy Markdown

msftclas commented May 28, 2018

CLA assistant check
All CLA requirements met.

@h-h-h-h
Copy link
Copy Markdown
Contributor Author

h-h-h-h commented May 28, 2018

Related issue: #42203.

@alexdima
Copy link
Copy Markdown
Member

👍 Thank you!

@alexdima alexdima merged commit 1ba11c0 into microsoft:master May 28, 2018
@alexdima alexdima added this to the May 2018 milestone May 28, 2018
@h-h-h-h h-h-h-h deleted the allow-deep-indent-as-line-wrapping-mode branch May 29, 2018 01:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants