Add V8 version to about dialog and prettify it#51511
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Jun 11, 2018
Merged
Add V8 version to about dialog and prettify it#51511bpasero merged 1 commit intomicrosoft:masterfrom
bpasero merged 1 commit intomicrosoft:masterfrom
Conversation
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following small changes to the About dialog (Help -> About):
I think the renames make it more clear what exactly the versions are referring to, and the colons are just to visually separate the labels from the versions better. As for the V8 version, I think it's worth noting independently (since Node already is as well, even though it can also typically be assumed by the Electron version).
I looked into the localisation changes necessary for these text changes, but am not sure exactly what procedure needs to be followed to associate the changes with this PR (if any). Please correct me if you find any issues with this PR. Thanks!