Improve i18n of new task identifier related strings#52019
Merged
isidorn merged 2 commits intomicrosoft:masterfrom Jun 15, 2018
Merged
Improve i18n of new task identifier related strings#52019isidorn merged 2 commits intomicrosoft:masterfrom
isidorn merged 2 commits intomicrosoft:masterfrom
Conversation
isidorn
reviewed
Jun 15, 2018
| const taskDisplayName = typeof taskId === 'string' ? `'${taskId}'` : nls.localize('specified', "specified"); | ||
| if (!task) { | ||
| return TPromise.wrapError(errors.create(nls.localize('DebugTaskNotFound', "Could not find the task {0}.", taskDisplayName))); | ||
| if (typeof taskId === 'string') |
Collaborator
There was a problem hiding this comment.
Use brackets {} after an if
Also based on the state construct the message and then in bot hcases just wrap error. Same as you do below
Collaborator
|
Thanks for your PR. I have added a comment. Once you adress this we can merge in this PR |
Contributor
Author
|
@isidorn: Done! |
Collaborator
|
Thanks for the pr. That was sloppy, had to fix some issues (formating, message not passed ,wrong id used) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new task identifier related strings introduced by @isidorn in cc5c103 can have a task Id substituted or not, in this case 'specified' string will be used. In this current form it cannot be correctly translated to Hungarian (and possibly to other languages). I split the two possibilities (one with task ID and the other without task Id) to two distinct error messages in both cases.