New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n of new task identifier related strings #52019

Merged
merged 2 commits into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@qcz
Contributor

qcz commented Jun 15, 2018

The new task identifier related strings introduced by @isidorn in cc5c103 can have a task Id substituted or not, in this case 'specified' string will be used. In this current form it cannot be correctly translated to Hungarian (and possibly to other languages). I split the two possibilities (one with task ID and the other without task Id) to two distinct error messages in both cases.

if (!task) {
return TPromise.wrapError(errors.create(nls.localize('DebugTaskNotFound', "Could not find the task {0}.", taskDisplayName)));
if (typeof taskId === 'string')

This comment has been minimized.

@isidorn

isidorn Jun 15, 2018

Contributor

Use brackets {} after an if
Also based on the state construct the message and then in bot hcases just wrap error. Same as you do below

@isidorn

This comment has been minimized.

Contributor

isidorn commented Jun 15, 2018

Thanks for your PR. I have added a comment. Once you adress this we can merge in this PR

@isidorn isidorn self-assigned this Jun 15, 2018

@isidorn isidorn added this to the June 2018 milestone Jun 15, 2018

@qcz

This comment has been minimized.

Contributor

qcz commented Jun 15, 2018

@isidorn: Done!

@isidorn isidorn merged commit f31466f into Microsoft:master Jun 15, 2018

1 of 2 checks passed

VSTS: VS Code 20180615.32 failed
Details
license/cla All CLA requirements met.
@isidorn

This comment has been minimized.

Contributor

isidorn commented Jun 15, 2018

Thanks for the pr. That was sloppy, had to fix some issues (formating, message not passed ,wrong id used)
0a0169b

@qcz qcz deleted the qcz:patch-6 branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment