New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding electron ARM and ARM64 tasks for cross-compiling #58436

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
2 participants
@headmelted
Contributor

headmelted commented Sep 11, 2018

This follows on from pull request #52119.

Adding these tasks will allow for explicitly downloading ARM and ARM64 versions of Electron when it is not the native architecture of the build machine (this is helpful for cross-compilation scenarios).

Adding electron ARM and ARM64 tasks
Adding tasks to allow for explicitly download ARM and ARM64 versions of Electron when it is not the native architecture of the build machine (for cross-compiling).

@joaomoreno joaomoreno added this to the September 2018 milestone Sep 11, 2018

@joaomoreno joaomoreno self-assigned this Sep 11, 2018

@joaomoreno joaomoreno merged commit 25832c1 into Microsoft:master Sep 11, 2018

1 of 2 checks passed

VS Code #20180911.39 failed
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 11, 2018

Member

Thanks! 🍻

Member

joaomoreno commented Sep 11, 2018

Thanks! 🍻

@headmelted

This comment has been minimized.

Show comment
Hide comment
@headmelted

headmelted Sep 12, 2018

Contributor

Thanks for the fast turnaround 👍

Contributor

headmelted commented Sep 12, 2018

Thanks for the fast turnaround 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment