New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check only dot at the end of a branch #58825

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@oneslash
Contributor

oneslash commented Sep 17, 2018

Fixes: #58816

Branches can contain "." (dot) but not at the end or beginning.

They cannot end with a dot

https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html

@oneslash oneslash changed the title from check only dot at the end of the branch to check only dot at the end of a branch Sep 17, 2018

@oneslash

This comment has been minimized.

Show comment
Hide comment
@oneslash

oneslash Sep 17, 2018

Contributor

@joaomoreno, would you check my PR?

Contributor

oneslash commented Sep 17, 2018

@joaomoreno, would you check my PR?

@octref octref requested a review from joaomoreno Sep 17, 2018

@joaomoreno joaomoreno added the git label Sep 18, 2018

@joaomoreno joaomoreno added this to the September 2018 milestone Sep 18, 2018

@joaomoreno joaomoreno merged commit d26c044 into Microsoft:master Sep 18, 2018

2 checks passed

VS Code #20180917.40 succeeded with issues
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 18, 2018

Member

Thanks! 🎆

Member

joaomoreno commented Sep 18, 2018

Thanks! 🎆

@oneslash oneslash deleted the oneslash:58816 branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment