New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow snippet json prefix to be an array to support multiple prefixes for the same snippet #59092

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
3 participants
@noamyogev84
Contributor

noamyogev84 commented Sep 21, 2018

Feature request #42838.
detailed information in commit message.

modified languageScopeSchema,globalSchema to allow prefix of type array.
modified _parseSnippet to push new snippet for each prefix (or for a single one)
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 21, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Sep 21, 2018

CLA assistant check
All CLA requirements met.

@jrieken jrieken self-assigned this Sep 21, 2018

@jrieken

lgtm. Thanks!

@jrieken jrieken added this to the September 2018 milestone Sep 21, 2018

@jrieken jrieken added the snippets label Sep 21, 2018

@jrieken jrieken merged commit 8e89438 into Microsoft:master Sep 21, 2018

2 checks passed

VS Code #20180921.38 succeeded with issues
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment