This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Use pinned query text, show PAT nag message, stop signout message#139
Merged
Use pinned query text, show PAT nag message, stop signout message#139
Conversation
added 2 commits
March 3, 2017 10:28
Pinned query text will choose either the query specified in the user settings (which can be wiql or a query path) or a default of WitQueries.MyWorkItems.
We're removing support for PAT tokens in user settings so if we find one, send telemetry about it, ignore it, and display a warning message to the user. Only show the warning (nag) message once (on initialization). If re-initialization occurs, don't show the nag message again. If VS Code is restarted and the token is still present, then we'll show the nag message again. On signout, reinitialization happens. When it does, we always show the message that there's no credentials stored for the account (duh; we just removed them). So prevent that message from being shown when re-init happens via signout.
jpricket
reviewed
Mar 3, 2017
src/helpers/strings.ts
Outdated
| static NoTfvcBuildsFound: string = "No builds were found for this repository. Click to view your team project's build definitions page."; | ||
| static NoRepoInformation: string = "No Team Services or Team Foundation Server repository configuration was found. Ensure you've opened a folder that contains a repository."; | ||
| static NoSourceFileForBlame: string = "A source file must be opened to show blame information."; | ||
| static FoundTokenInSettings: string = "A PAT was found in your VS Code settings. It will be ignored and you should remove it. You may then need to run the 'team signin' command."; |
Member
There was a problem hiding this comment.
Maybe instead of "You may then need..." something like "You should now use the Sign In command to store your PAT in a secure location."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned query text will choose either the query specified in the user settings (which can be wiql or a query path) or a default of WitQueries.MyWorkItems.
We're removing support for PAT tokens in user settings so if we find one, send telemetry about it, ignore it, and display a warning message to the user. Only show the warning (nag) message once (on initialization). If re-initialization occurs, don't show the nag message again. If VS Code is restarted and the token is still present, then we'll show the nag message again.
On signout, reinitialization happens. When it does, we always show the message that there's no credentials stored for the account (duh; we just removed them). So prevent that message from being shown when re-init happens via signout.