This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fix VSTS URL detection for "new-style" SSH clones#334
Merged
kaylangan merged 1 commit intomicrosoft:masterfrom Nov 8, 2017
bearcage:master
Merged
Fix VSTS URL detection for "new-style" SSH clones#334kaylangan merged 1 commit intomicrosoft:masterfrom bearcage:master
kaylangan merged 1 commit intomicrosoft:masterfrom
bearcage:master
Conversation
Since VSTS has changed their url scheme, the "contains _git" heuristic used to identify all tfs/vsts urls no longer applies. Moreover, the code that constructs the VSO url from the git remote won't work either, since both the hostname and the path are wrong. This PR fixes both issues. See issue #330 for full context / initial report.
Contributor
|
@aberghage thanks for your contribution! |
|
Is there a date when this change will be released? I just installed the extension and couldn't get it working until I found this issue 30 min later... it should at least be documented somewhere, that it currently doesn't work out of the box with SSH URLs. |
Closed
|
I'd like to see this fix released too. I'm new to VSTS and wasn't around when the ssh URL changed. That made it even harder for me to figure out the problem wasn't with me but with the extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since VSTS has changed their url scheme, the "contains _git"
heuristic used to identify all tfs/vsts urls no longer applies.
Moreover, the code that constructs the VSO url from the git
remote won't work either, since both the hostname and the path
are wrong.
This PR fixes both issues.
See issue #333 for full context / initial report.
EDIT: typo'd the original reporting issue, should be 333 not 330.