Skip to content

Conversation

@JamesDBartlett3
Copy link
Contributor

  • Detect Raspberry Pi OS kernel mode (32-bit or 64-bit)
  • Query GitHub Releases API for latest PowerShell release files
  • Parse results for the tar.gz file whose architecture matches the detected kernel mode, and store it in the latest_build variable
  • Use wget to download file at latest_build
  • Parse downloaded tar.gz filename from latest_build and extract its contents to ~/powershell

PR Summary

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

- Detect Raspberry Pi OS kernel mode (32-bit or 64-bit)
- Query GitHub Releases API for latest PowerShell release files
- Parse results for the tar.gz file whose architecture matches the detected kernel mode, and store it in the `latest_build` variable
- Use `wget` to download file at `latest_build`
- Parse downloaded tar.gz filename from `latest_build` and extract its contents to `~/powershell`
@github-actions
Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 4115f18:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/install/install-raspbian.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler
Copy link
Collaborator

@JamesDBartlett3 Thanks for the contribution. This looks like a great option for your personal toolkit. However, for the documentation, we need to keep the logic as simple as possible.

@sdwheeler sdwheeler closed this Aug 30, 2023
@JamesDBartlett3
Copy link
Contributor Author

JamesDBartlett3 commented Aug 30, 2023

@sdwheeler When I ran the code from the current installation instructions on my Raspberry Pi, it didn't work, because my Raspberry Pi is 64-bit. If you're trying to make this "as simple as possible," then it really should automatically detect the current system's kernel mode and install the appropriate build of PowerShell for that kernel mode.

@sdwheeler
Copy link
Collaborator

There are several issues with this.

  • Your changes don't work for 32-bit - it should test for 7l not 71
  • A better way to test for 32/64-bit is to use the command getconf LONG_BIT
  • We have only ever supported 32-bit for Raspberry Pi
  • We no longer officially support Raspberry Pi because we no longer test it - so the docs need to be updated

@JamesDBartlett3
Copy link
Contributor Author

* Your changes don't work for 32-bit - it should test for `7l` not `71`

I already fixed that in my fork, but since you closed the PR, that commit isn't showing up here.

* A better way to test for 32/64-bit is to use the command `getconf LONG_BIT`

OK, I can do that. Why wasn't this suggested before, instead of just closing the PR?

* We have only ever supported 32-bit for Raspberry Pi

Then why is there a 64-bit ARM tarball in the releases page?

* We no longer officially support Raspberry Pi because we no longer test it - so the docs need to be updated

If the Raspberry Pi is no longer tested or supported, why does this page still exist at all?

@sdwheeler
Copy link
Collaborator

The 64-bit ARM tarballs are supported for other OS versions. I am in the process of removing the Raspberry Pi documentation from the list of supported versions. Stay tuned for updates.

@sdwheeler sdwheeler mentioned this pull request Sep 6, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants