Creating Feedback Provider Docs #10381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenBucher98
requested review from
michaeltlombardi and
sdwheeler
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
ExpectationsThanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it. To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details. The docs team begins to review your PR if you request them to or if your PR meets these conditions:
You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge. While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST). |
StevenBucher98
commented
Aug 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
sdwheeler
force-pushed
the
feedbackprovider
branch
from
ca26472 to
bc2fc48
Compare
This comment was marked as outdated.
This comment was marked as outdated.
sdwheeler
requested changes
Sep 1, 2023
Collaborator
sdwheeler
left a comment
sdwheeler
left a comment
There was a problem hiding this comment.
@StevenBucher98 I did a full editorial pass with numerous changes. There is one TODO item left for you. Add instructions on how to build, package, and import the module.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Learn Build status updates of commit 7473827: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Collaborator
|
@StevenBucher98 just waiting on sign-off from @daxian-dbw. |
Contributor
|
Learn Build status updates of commit 7aed4de: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
sdwheeler
force-pushed
the
feedbackprovider
branch
from
7aed4de to
7e467ee
Compare
Contributor
|
Learn Build status updates of commit 7e467ee: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
daxian-dbw
requested changes
Sep 6, 2023
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
Contributor
|
Learn Build status updates of commit 7e2f212: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…der.md Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Contributor
|
Learn Build status updates of commit 5f8fc8f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit 6c91de5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit e3daaaf: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit 3316faa: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
Contributor
|
Learn Build status updates of commit 0033920: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit 0cbbf63: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit 1e3b667: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
daxian-dbw
requested changes
Sep 7, 2023
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
Comment on lines
608
to
609
| } | ||
|
|
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
Contributor
|
Learn Build status updates of commit 434d3e6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit e606b59: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
|
Learn Build status updates of commit d6d79aa: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
daxian-dbw
previously approved these changes
Sep 7, 2023
reference/docs-conceptual/dev-cross-plat/create-feedback-provider.md
Outdated
Show resolved
Hide resolved
Contributor
|
Learn Build status updates of commit a40ff6e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
sdwheeler
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is first pass at creating a feedback provider doc. This doc outlines how to create a feedback provider that triggers on success and errors in the commandline. The success case only triggers if the user is using an aliased command and will provide feedback that it is in fact aliased and include the full name of the command. The error case will trigger when there is an error in the cmd and suggest the user try using
Get-Helpor check out online docs.PR Checklist