Skip to content

Conversation

@PerOve
Copy link

@PerOve PerOve commented Nov 4, 2015

Missing Role in nodename VM-1

Missing Role in nodename VM-1
@msftclas
Copy link

msftclas commented Nov 4, 2015

Hi @PerOve, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@joeyaiello
Copy link
Contributor

Hi @PerOve,

This looks great! Thanks so much for being our first external contributor.

If I could ask one favor: would you mind basing your pull request against PowerShell:master instead of PowerShell:live. Per #38, we need to be a lot more explicit about our branching strategy, and it looks like we may have a bug where our check fails on a PR to master (which should definitely be fixed). However, we still need to propagate changes through a staging branch before going to live.

Thanks,
Joey

@ghost ghost closed this Feb 4, 2016
@ghost
Copy link

ghost commented Feb 4, 2016

Addressed with #146

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants