Skip to content

10/27 PM Publish #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
huypub merged 2 commits into from
Oct 27, 2021
Merged

10/27 PM Publish #8266

huypub merged 2 commits into from
Oct 27, 2021

Conversation

@huypub
Copy link
Contributor

@huypub huypub commented Oct 27, 2021

No description provided.

philanderson888 and others added 2 commits October 27, 2021 10:59
@philanderson888 @sdwheeler
Update Installing-PowerShell-on-Windows.md (#8264)
79262d8 
* Update Installing-PowerShell-on-Windows.md

Existing notes on the correct way to install powershell using `winget` were inaccurate.  I have added more complete notes which add installing by name, id and also version.  The existing command using the `exact` parameter was incorrect so I have removed it.

* Update reference/docs-conceptual/install/Installing-PowerShell-on-Windows.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>

* Update Installing-PowerShell-on-Windows.md

However I tried the syntax of your suggested change @sdwheeler and still found this syntax to be incorrect.  

I have therefore proposed a change which works syntactically and Powershell accepts.

Please review the changes and let me know what you think.

Thank you.

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
@sdwheeler
Add $this for event senders (#8265)
c5fec71
@opbld32
Copy link

opbld32 commented Oct 27, 2021

Docs Build status updates of commit c5fec71:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@huypub huypub closed this Oct 27, 2021
@huypub huypub reopened this Oct 27, 2021
@opbld30
Copy link

opbld30 commented Oct 27, 2021

Docs Build status updates of commit c5fec71:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-5.1)
reference/7.0/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-7)
reference/7.1/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-7.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded View (powershell-7.2)
reference/docs-conceptual/install/Installing-PowerShell-on-Windows.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@huypub huypub merged commit e745f6b into live Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@huypub @opbld32 @opbld30 @philanderson888 @sdwheeler