Improve C2548 #4964
Merged
Improve C2548 #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 7c9691c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
PRMerger Results
|
Contributor
#label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
TylerMSFT
approved these changes
Mar 1, 2024
Collaborator
TylerMSFT
left a comment
TylerMSFT
left a comment
There was a problem hiding this comment.
I agree that your changes improve the sample.
All I did was make the description you provided faster to parse.
Contributor
|
Learn Build status updates of commit 08d65c1: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
PRMerger Results
|
fixed title casing
Contributor
|
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit 4966848: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
PRMerger Results
|
Contributor
|
Learn Build status updates of commit fda4ca2: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Contributor
PRMerger Results
|
Collaborator
|
#sign-off |
learn-build-service-prod bot
added a commit
that referenced
this pull request
Mar 2, 2024
* Fixes #3014 * Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#5198) * largeaddressaware:no is not recommended for 64-bit apps * Update connect-to-your-remote-linux-computer.md Removing references to RSA/DSA keys due to security concerns * Update largeaddressaware-handle-large-addresses.md * Update largeaddressaware-handle-large-addresses.md * Update largeaddressaware-handle-large-addresses.md * Fixed syntax error in example message * Update clang-tidy.md Adding support for CMake Presets * Update clang-tidy.md addressing some feedback * Update assignment-operators.md Clarify built-in behaviour for compound assignment. Add mention of overloaded compound assignment operators Fixes #4745 * Update gmtime-s-gmtime32-s-gmtime64-s.md Remove note about daylight savings time, as these functions convert from time-since-epoch to UTC, neither of which are affected by daylight savings * Update gmtime-gmtime32-gmtime64.md * Correct JSON output of sourcedependencies.md Updates the version number in the JSON to the one currently used by the compiler, and removes the bogus ImportedHeaderUnit entry * update date * Update gmtime-gmtime32-gmtime64.md update ms.date * Update gmtime-s-gmtime32-s-gmtime64-s.md update date * Update assignment-operators.md update ms.date * Repo sync for protected branch (#4958) * add link to backend improvements * change feedback system from github issues to the new UUF system (#5208) Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> * new article: include diagnostics * acrolinx and edit * acrolinx * small edits * clarified specific to C++ * clarify that this is C++ include diagnostics * fix github #4953 --------- Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> Co-authored-by: Phil <v-jiakan@microsoft.com> Co-authored-by: James Barnett <v-jabarnett@microsoft.com> Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com> * Update clang-tidy.md * Update clang-tidy.md * Update clang-tidy.md * header casing & markdown syntax tweaks * Update docs/code-quality/clang-tidy.md * Fix built-in operators toc yml * Update subscript-operator.md * Update left-shift-and-right-shift-operators-input-and-output.md * Update subscript-operator.md * Improve C2548 (#4964) * Improve C2548 * Update compiler-error-c2548.md * Update compiler-error-c2548.md fixed title casing * Update compiler-error-c2548.md typo --------- Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> * Remove extra trailing comma in istream iterator (#4962) * Make built-in operators title consistent (#4963) * Fixes #3014 (#5221) Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> --------- Co-authored-by: mspll <109390104+mspll@users.noreply.github.com> Co-authored-by: Sinem Akinci <99284450+sinemakinci1@users.noreply.github.com> Co-authored-by: Phil <v-jiakan@microsoft.com> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: Alma Jenks <v-alje@microsoft.com> Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com> Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com> Co-authored-by: Jak Koke <v-jokoke@microsoft.com> Co-authored-by: Javad Kouchakzadeh <stoopdapoop@users.noreply.github.com> Co-authored-by: Sy Brand <tartanllama@gmail.com> Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> Co-authored-by: James Barnett <v-jabarnett@microsoft.com> Co-authored-by: Rageking8 <106309953+Rageking8@users.noreply.github.com> Co-authored-by: Taojunshen <v-jutao@microsoft.com> --------- Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: mspll <109390104+mspll@users.noreply.github.com> Co-authored-by: Sinem Akinci <99284450+sinemakinci1@users.noreply.github.com> Co-authored-by: Phil <v-jiakan@microsoft.com> Co-authored-by: Alma Jenks <v-alje@microsoft.com> Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com> Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com> Co-authored-by: Jak Koke <v-jokoke@microsoft.com> Co-authored-by: Javad Kouchakzadeh <stoopdapoop@users.noreply.github.com> Co-authored-by: Sy Brand <tartanllama@gmail.com> Co-authored-by: James Barnett <v-jabarnett@microsoft.com> Co-authored-by: Rageking8 <106309953+Rageking8@users.noreply.github.com>
learn-build-service-prod bot
added a commit
that referenced
this pull request
Mar 4, 2024
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#5198) * largeaddressaware:no is not recommended for 64-bit apps * Update connect-to-your-remote-linux-computer.md Removing references to RSA/DSA keys due to security concerns * Update largeaddressaware-handle-large-addresses.md * Update largeaddressaware-handle-large-addresses.md * Update largeaddressaware-handle-large-addresses.md * Fixed syntax error in example message * Update clang-tidy.md Adding support for CMake Presets * Update clang-tidy.md addressing some feedback * Update assignment-operators.md Clarify built-in behaviour for compound assignment. Add mention of overloaded compound assignment operators Fixes #4745 * Update gmtime-s-gmtime32-s-gmtime64-s.md Remove note about daylight savings time, as these functions convert from time-since-epoch to UTC, neither of which are affected by daylight savings * Update gmtime-gmtime32-gmtime64.md * Correct JSON output of sourcedependencies.md Updates the version number in the JSON to the one currently used by the compiler, and removes the bogus ImportedHeaderUnit entry * update date * Update gmtime-gmtime32-gmtime64.md update ms.date * Update gmtime-s-gmtime32-s-gmtime64-s.md update date * Update assignment-operators.md update ms.date * Repo sync for protected branch (#4958) * add link to backend improvements * change feedback system from github issues to the new UUF system (#5208) Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> * new article: include diagnostics * acrolinx and edit * acrolinx * small edits * clarified specific to C++ * clarify that this is C++ include diagnostics * fix github #4953 --------- Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> Co-authored-by: Phil <v-jiakan@microsoft.com> Co-authored-by: James Barnett <v-jabarnett@microsoft.com> Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com> * Update clang-tidy.md * Update clang-tidy.md * Update clang-tidy.md * header casing & markdown syntax tweaks * Update docs/code-quality/clang-tidy.md * Fix built-in operators toc yml * Update subscript-operator.md * Update left-shift-and-right-shift-operators-input-and-output.md * Update subscript-operator.md * Improve C2548 (#4964) * Improve C2548 * Update compiler-error-c2548.md * Update compiler-error-c2548.md fixed title casing * Update compiler-error-c2548.md typo --------- Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> * Remove extra trailing comma in istream iterator (#4962) * Make built-in operators title consistent (#4963) * Fixes #3014 (#5221) Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> --------- Co-authored-by: mspll <109390104+mspll@users.noreply.github.com> Co-authored-by: Sinem Akinci <99284450+sinemakinci1@users.noreply.github.com> Co-authored-by: Phil <v-jiakan@microsoft.com> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: Alma Jenks <v-alje@microsoft.com> Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com> Co-authored-by: Tyler Whitney <TylerMSFT@users.noreply.github.com> Co-authored-by: Courtney Wales <62625502+Court72@users.noreply.github.com> Co-authored-by: Jak Koke <v-jokoke@microsoft.com> Co-authored-by: Javad Kouchakzadeh <stoopdapoop@users.noreply.github.com> Co-authored-by: Sy Brand <tartanllama@gmail.com> Co-authored-by: TylerMSFT <Tyler.Whitney@microsoft.com> Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com> Co-authored-by: James Barnett <v-jabarnett@microsoft.com> Co-authored-by: Rageking8 <106309953+Rageking8@users.noreply.github.com> Co-authored-by: Taojunshen <v-jutao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave the function argument names so as to not confuse people unfamiliar with the
int = 1syntax, and it is needed for the example explanation. The example explanation is slightly verbose to prevent it from being ambiguous or imprecise, since the default argument requirement is technically the "union" of all preceding declarations within the same scope. Happy to receive feedback on a terser method.