Skip to content

Conversation

@robertpp
Copy link
Contributor

@robertpp robertpp commented Jul 6, 2022

The default value for AllowEngagementReport is Enabled if no value is specified when the Teams meeting policy is created from PowerShell. This is the opposite of what happens when a new meeting policy is created in Teams admin center.

image

The default value for AllowEngagementReport is Enabled if no value is specified when the Teams meeting policy is created from PowerShell.
@opbld31
Copy link

opbld31 commented Jul 6, 2022

Docs Build status updates of commit c05afa8:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/New-CsTeamsMeetingPolicy.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@yogkumgit yogkumgit self-assigned this Jul 6, 2022
@yogkumgit yogkumgit requested review from a user, dariomws and get-itips July 6, 2022 15:25
@yogkumgit
Copy link

@JohanFreelancer9

@yogkumgit
Copy link

@dariomws @get-itips @tseward

@get-itips
Copy link
Contributor

Hello @robertpp Robert
Actually, the new policy values will depend of the current values in Global policy at the time of the cmdlet run:

image

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review.

@yogkumgit
Copy link

@robertpp

Copy link
Contributor

@dariomws dariomws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @get-itips, we saw this before.

@robertpp
Copy link
Contributor Author

robertpp commented Jul 8, 2022

Hi @get-itips , thanks for the information, I wasn't aware of it. I confirm seeing the same behavior in our tenant, but totally missed the Global policy was no longer set to the default. This should be reflected in the documentation, as it is confusing, especially since the TAC behavior is different.

I would suggest the following changes:
a. Include a mention in the description: The default value of AllowEngagementReport in the Global policy is Disabled.
b. Set 'Default value:' to 'Matches (value in) Global policy'.

@get-itips
Copy link
Contributor

Hello @robertpp how are you? the default value in the Global policy is not disabled, it's just that in my lab I changed it to disabled.

We can't put this Matches (value in) Global policy for Default value field as it is expecting a value or None, the general convention is using None when the value can not be exactly determined as it depends on Global policy/current settings in customer tenant.

I think we should leave this article as-is.

Thank you!

@yogkumgit
Copy link

@robertpp Please comment.

@robertpp
Copy link
Contributor Author

Thank you for the comment @get-itips . I understand now the reason for None. The documentation says the meeting attendance reports download is off by default, which to me it means the default value in the Global policy is turned off.

image

The confusion starts when AllowEngagementReport in the Global policy is turned on. To prevent false expectations, it might be worth indicating the dependency on the value of AllowEngagementReport in the Global policy for subsequent policies.

@get-itips
Copy link
Contributor

It seems that sentence is outdated as the linked article says

This policy is on by default and allows your organizers to see who registered and attended the meetings and webinars they set up.

On new tenants, in the global policy, it appears to be on by default.

So I think the article requiring an edit is the one you linked that says it is off by default.

About this one, a note can be added that the initial values of the new policy are copied from the Global one.

@robertpp
Copy link
Contributor Author

Hi @get-itips . Thank you for the feedback. I raised another item for the other article. It's surprising to learn that it is enabled by default in Global policy. The entire documentation, including internal, except the article you mentioned, indicates it is off by default for privacy reasons. I even have a case where the customer is complaining about the feature not being compliant with GDPR. That's how I got to raise these items. Your efforts and clarifications are much appreciated.

@get-itips
Copy link
Contributor

@dariomws can you check on your tenants?

@dariomws
Copy link
Contributor

@get-itips @robertpp, it's enabled in my demo tenant, it should be the default value for the Global policy.

@robertpp
Copy link
Contributor Author

Thank you for confirmation, @dariomws .

@yogkumgit
Copy link

@get-itips @dariomws

@yogkumgit yogkumgit removed the request for review from a user July 20, 2022 07:08
@get-itips
Copy link
Contributor

@robertpp Robert, sorry, on my opinion, I was more inclined to leave "None" as value.

the general convention is using None when the value can not be exactly determined as it depends on Global policy/current settings in customer tenant.

About this one, a note can be added that the initial values of the new policy are copied from the Global one.

@dariomws thoughts?

@dariomws
Copy link
Contributor

Agree with @get-itips.

@yogkumgit
Copy link

@robertpp Please comment

@yogkumgit
Copy link

@robertpp How you wish to proceed with this PR. Please suggest.
CC: @tiburd

@robertpp
Copy link
Contributor Author

robertpp commented Aug 1, 2022

Hello @yogkumgit and @tiburd . Apologies for the slow follow up. I was on vacation the past 2 weeks. I agree with @get-itips' suggestion.

@yogkumgit
Copy link

@robertpp Thank you and no worries. I am closing it.

@yogkumgit yogkumgit closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants