Skip to content

Conversation

@riverar
Copy link
Contributor

@riverar riverar commented Jan 17, 2024

After investigating a reported TreeView_SortChildren issue, it was determined that the default TreeView sorting callback (comctl32!TV_SortCB) receives the recurse flag value but doesn't do anything with it. It remains unimplemented in Common Controls v5 and v6.

@prmerger-automator
Copy link

@riverar : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jwmsft jwmsft merged commit a669a86 into MicrosoftDocs:docs Feb 9, 2024
@riverar riverar deleted the patch-2 branch February 9, 2024 22:21
@gonutz
Copy link

gonutz commented Feb 10, 2024

I just took a look at your change. You say Not implemented; see remarks but the remarks were not updated and they do not mention this at all.

@riverar
Copy link
Contributor Author

riverar commented Feb 10, 2024

@gonutz That was intentional. It already says:

[...] You can use the TVM_SORTCHILDRENCB message to customize the ordering behavior.

Do you think we're missing something there?

@gonutz
Copy link

gonutz commented Feb 10, 2024

The way I read the doc page now is that the function has a parameter recurse which makes it pretty obvious what it is for. Then I read it is not implemented. That is OK (Maybe I would have changed the name here to something like reserved, but the SDK header files would still have it be recurse so this might create extra confusion). The part that looks like something is missing is the see remarks part here. This makes me expect a reason or further explanation for why this is not impemented. Escpecially since there is now no obvious way to sort a tree recursively. Users have to implement this themselves. The remarks explain only how to sort in a way other than alphabetically, not how to do it recursively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants