CreateEventEx: Clarify that zero flags is also OK #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nir9 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
| ### -param dwFlags [in] | ||
|
|
||
| This parameter can be one or more of the following values. | ||
| This parameter can be zero or more of the following values. |
Collaborator
There was a problem hiding this comment.
Revise to: "This parameter can be 0 or one of the following values."
| ### -param dwFlags [in] | ||
|
|
||
| This parameter can be one or more of the following values. | ||
| This parameter can be zero or more of the following values. |
Collaborator
There was a problem hiding this comment.
Revise to: "This parameter can be 0 or one of the following values."
Collaborator
|
Hi @nir9 - I've added comments to your requested revisions as I'm unable to edit the files in your PR from a fork. I suggest you use our standard edit and PR process for future updates. Thanks. |
Contributor
Author
|
@Karl-Bridge-Microsoft Roger will take note for next times, fixed the CR comments. |
Karl-Bridge-Microsoft
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that it is also possible to pass zero flags to the
dwFlagsparam and it is not required to pass at least one of the flags. Similar to how it is written inCreateMutexExWConfirmed that passing zero flags works as expected with WinObj: