GetDiskSpaceInformationW: Fix wrong return values #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@autoantwort : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
sdk-api-src/content/fileapi/nf-fileapi-getdiskspaceinformationw.md
Outdated
Show resolved
Hide resolved
alvinashcraft
approved these changes
May 21, 2025
Contributor
alvinashcraft
left a comment
alvinashcraft
left a comment
There was a problem hiding this comment.
Thanks for this update. It looks like the same changes are needed in GetDiskSpaceInformationA (and possibly other APIs in fileapi.h). I'll create an internal work item to work on finding other issues with return info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nasty thing is if you rely on the docs you want
TRUEwhich is 1 butS_OKis 0 so the function "always fails"